linux-kernel - Re: linux-next: build warning after merge of the drivers-x86 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 May 2017 21:03:06 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Darren Hart <dvhart@...radead.org>, Arnd Bergmann <arnd@...db.de>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ritesh Raj Sarraf <rrs@...ian.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: linux-next: build warning after merge of the drivers-x86 tree

On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@...radead.org> wrote:
> On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> Hi Darren,
>>
>> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
>>  static ssize_t touchpad_store(struct device *dev,
>>                 ^
>>
>> Introduced by commit
>>
>>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
>
> Thank you Stephen,
>
> Andy, you warned me about this and I had forgotten before I included it in next.
>
> Would you like to drop this change, or drop the touchpad_store function?

I would go with Arnd's patch if he respins one addressing my comment.

-- 
With Best Regards,
Andy Shevchenko