linux-kernel - Re: [PATCH 4/7] perf script: Add --inline option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 May 2017 16:13:30 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, kernel-team@....com,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Milian Wolff <milian.wolff@...b.com>,
        Yao Jin <yao.jin@...ux.intel.com>
Subject: Re: [PATCH 4/7] perf script: Add --inline option

On Wed, May 24, 2017 at 08:38:11AM +0200, Ingo Molnar wrote:
> 
> * Namhyung Kim <namhyung@...nel.org> wrote:
> 
> > The --inline option is to show inlined functions in callchains.
> > 
> > For example,
> > 
> >   $ perf script
> >   a.out  5644 11611.467597:     309961 cycles:u:
> >                      790 main (/home/namhyung/tmp/perf/a.out)
> >                    20511 __libc_start_main (/usr/lib/libc-2.25.so)
> >                      8ba _start (/home/namhyung/tmp/perf/a.out)
> >   ...
> > 
> >   $ perf script --inline
> >   a.out  5644 11611.467597:     309961 cycles:u:
> >                      790 main (/home/namhyung/tmp/perf/a.out)
> >                          std::__detail::_Adaptor<std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul>, double>::operator()
> >                          std::uniform_real_distribution<double>::operator()<std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> >
> >                          std::uniform_real_distribution<double>::operator()<std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> >
> >                          main
> >                    20511 __libc_start_main (/usr/lib/libc-2.25.so)
> >                      8ba _start (/home/namhyung/tmp/perf/a.out)
> >   ...
> 
> Shouldn't this be the default behavior, to make call chains more readable?

AFAIK perf report didn't make it default due to a performance impact,
but I didn't know how much it is.  Especially if perf was not built
with libbfd it'll run external addr2line to get inlined functions for
each callchain entry..

Thanks,
Namhyung