linux-kernel - Re: [PATCH] platform/x86: intel_pmc_ipc: Delete unused function ipc_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 May 2017 14:39:32 +0100
From:   Alan Cox <gnomes@...rguk.ukuu.org.uk>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Zha Qipeng <qipeng.zha@...el.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH] platform/x86: intel_pmc_ipc: Delete unused function
 ipc_data_readb()

On Tue, 23 May 2017 13:55:39 -0700
Matthias Kaehlcke <mka@...omium.org> wrote:

> The function was added by commit 0a8b83530b6f ("intel_pmc_ipc: Add Intel
> Apollo Lake PMC IPC driver") in 2015 and hasn't been used since then.
> Removing it fixes the following warning when building with clang:
> 
>     drivers/platform/x86/intel_pmc_ipc.c:189:18: error: unused function
>         'ipc_data_readb' [-Werror,-Wunused-function]

It is however also part of the API and a consistent sensible function to
have present should it be needed. As it's static it's eliminated
correctly by gcc.

I'm all for eliminating unused functions but in this case I have to wonder

Alan