linux-kernel - Re: [PATCH] iio: hi8435: remote ampersands from hi8435

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 May 2017 20:28:53 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Sanchayan Maity <maitysanchayan@...il.com>,
        Gregor Boirie <gregor.boirie@...rot.com>,
        Matt Ranostay <mranostay@...il.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chris Healy <Chris.Healy@....aero>,
        Jeff White <Jeff.White@....aero>,
        Vladimir Barinov <vladimir.barinov@...entembedded.com>
Subject: Re: [PATCH] iio: hi8435: remote ampersands from hi8435_info
 definition

On Tue, 23 May 2017 11:07:46 +0300
Nikita Yushchenko <nikita.yoush@...entembedded.com> wrote:

> C syntax allows apersands when initializing structures fields with
> function pointers, but in Linux sources ampersands are normally not used
> in thix context.
> 
> Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>
Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,
Jonathan
> ---
>  drivers/iio/adc/hi8435.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c
> index 28fc699f00f6..ef5c286c8e67 100644
> --- a/drivers/iio/adc/hi8435.c
> +++ b/drivers/iio/adc/hi8435.c
> @@ -414,11 +414,11 @@ static const struct iio_chan_spec hi8435_channels[] = {
>  static const struct iio_info hi8435_info = {
>  	.driver_module = THIS_MODULE,
>  	.read_raw = hi8435_read_raw,
> -	.read_event_config = &hi8435_read_event_config,
> +	.read_event_config = hi8435_read_event_config,
>  	.write_event_config = hi8435_write_event_config,
> -	.read_event_value = &hi8435_read_event_value,
> -	.write_event_value = &hi8435_write_event_value,
> -	.debugfs_reg_access = &hi8435_debugfs_reg_access,
> +	.read_event_value = hi8435_read_event_value,
> +	.write_event_value = hi8435_write_event_value,
> +	.debugfs_reg_access = hi8435_debugfs_reg_access,
>  };
>  
>  static void hi8435_iio_push_event(struct iio_dev *idev, unsigned int val)