linux-kernel - Re: [PATCH] misc: ad525x_dpot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 27 May 2017 03:16:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Roshni Shah <roshni.shah@...esys.com>
Cc:     kbuild-all@...org, robh+dt@...nel.org, mark.rutland@....com,
        arnd@...db.de, gregkh@...uxfoundation.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Roshni Shah <roshni.shah@...esys.com>
Subject: Re: [PATCH] misc: ad525x_dpot_spi: Add device tree support

Hi Roshni,

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on v4.12-rc2 next-20170526]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Roshni-Shah/misc-ad525x_dpot_spi-Add-device-tree-support/20170527-023127
config: x86_64-randconfig-x010-201721 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/misc/ad525x_dpot-spi.c: In function 'ad_dpot_spi_probe':
>> drivers/misc/ad525x_dpot-spi.c:96:9: warning: passing argument 3 of 'ad_dpot_probe' makes integer from pointer without a cast [-Wint-conversion]
            of_id->data,
            ^~~~~
   In file included from drivers/misc/ad525x_dpot-spi.c:13:0:
   drivers/misc/ad525x_dpot.h:211:5: note: expected 'long unsigned int' but argument is of type 'const void * const'
    int ad_dpot_probe(struct device *dev, struct ad_dpot_bus_data *bdata,
        ^~~~~~~~~~~~~

vim +/ad_dpot_probe +96 drivers/misc/ad525x_dpot-spi.c

    80		.write_r8d8	= write16,
    81		.write_r8d16	= write24,
    82	};
    83	static int ad_dpot_spi_probe(struct spi_device *spi)
    84	{
    85		int ret;
    86		const struct of_device_id *of_id = of_match_device(ad_dpot_spi_of_match,
    87								   &spi->dev);
    88	
    89		struct ad_dpot_bus_data bdata = {
    90			.client = spi,
    91			.bops = &bops,
    92		};
    93	
    94		if (of_id) {
    95			ret = ad_dpot_probe(&spi->dev, &bdata,
  > 96				     of_id->data,
    97				     of_id->name);
    98		} else {
    99			ret = ad_dpot_probe(&spi->dev, &bdata,
   100				     spi_get_device_id(spi)->driver_data,
   101				     spi_get_device_id(spi)->name);
   102		}
   103	
   104		return ret;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (33810 bytes)