linux-kernel - Re: [PATCH v2] genirq: Check irq disabled & masked states in irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 27 May 2017 12:51:34 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     jeffy <jeffy.chen@...k-chips.com>
cc:     linux-kernel@...r.kernel.org, briannorris@...omium.org,
        dianders@...omium.org, tfiga@...omium.org
Subject: Re: [PATCH v2] genirq: Check irq disabled & masked states in
 irq_shutdown

On Sat, 27 May 2017, jeffy wrote:
> On 05/27/2017 04:30 PM, Thomas Gleixner wrote:
> > On Sat, 27 May 2017, Jeffy Chen wrote:
> > 
> > > If a irq is already disabled & masked, free_irq may cause a unbalanced
> > > irq shutdown/disable/mask, for example:
> > 
> > No, it's not. irq_shutdown/disable/mask are low level access functions
> > which can be invoked at any given time.
> > 
> > The only interface which has refcounting is disable/enable_irq().
> but i think it still be good trying to make them balance, at least for irq
> enable/disable :)

If we make them balanced then we do it proper and not just for the single
issue you are facing. And we do not try. We analyze it proper and fix it.

It's not rocket science, but yes it takes a bit longer than cobbling
something together which works just for you.

Thanks,

	tglx