linux-kernel - Re: [PATCH] regulator: bd9571mwv: Statize local symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 28 May 2017 14:20:25 +0200
From:   Marek Vasut <marek.vasut@...il.com>
To:     Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
Cc:     Marek Vasut <marek.vasut+renesas@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: bd9571mwv: Statize local symbols

On 05/28/2017 08:02 AM, Axel Lin wrote:
> These functions are only used by this driver, make them static.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Obviously correct,
Acked-by: Marek Vasut <marek.vasut@...il.com>

> ---
>  drivers/regulator/bd9571mwv-regulator.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c
> index 8ba206f..c67a83d 100644
> --- a/drivers/regulator/bd9571mwv-regulator.c
> +++ b/drivers/regulator/bd9571mwv-regulator.c
> @@ -43,7 +43,7 @@ enum bd9571mwv_regulators { VD09, VD18, VD25, VD33, DVFS };
>  		.linear_min_sel		= _lmin,		\
>  	}
>  
> -int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
> +static int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
>  {
>  	unsigned int val;
>  	int ret;
> @@ -55,8 +55,8 @@ int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
>  	return val & BD9571MWV_AVS_SET_MONI_MASK;
>  }
>  
> -int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
> -					 unsigned int sel)
> +static int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
> +						unsigned int sel)
>  {
>  	int ret;
>  
> @@ -68,7 +68,7 @@ int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
>  				 rdev->desc->vsel_mask, sel);
>  }
>  
> -int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
> +static int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
>  {
>  	unsigned int val;
>  	int ret;
> @@ -87,8 +87,8 @@ int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
>  	return val;
>  }
>  
> -int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev,
> -					 unsigned int sel)
> +static int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev,
> +						unsigned int sel)
>  {
>  	return regmap_write_bits(rdev->regmap, BD9571MWV_DVFS_SETVID,
>  				 rdev->desc->vsel_mask, sel);
> 


-- 
Best regards,
Marek Vasut