linux-kernel - Re: [PATCH v4] sgi-xp: Use designated initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 27 May 2017 21:59:59 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Cliff Whickman <cpw@....com>,
        Robin Holt <robinmholt@...il.com>,
        Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH v4] sgi-xp: Use designated initializers

On Sat, May 27, 2017 at 05:39:14PM -0700, Kees Cook wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. In this case, no initializers
> are needed (they can be NULL initialized and callers adjusted to check
> for NULL, which is more efficient than an indirect call).

I'd say this looks good:

Reviewed-by: Christoph Hellwig <hch@....de>

Until I noticed all this is unused, so we should just remove it
entirely.  I now remember the weird SGI excuse, but given that they
haven't managed to get their code upstream in more than 10 years there
is no valid reason at all to keep this around.