linux-kernel - Re: [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular distinctions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 May 2017 10:24:07 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Tomasz Figa <tomasz.figa@...il.com>,
        Thomas Abraham <thomas.ab@...sung.com>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular distinctions

On Mon, May 22, 2017 at 10:56 PM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> Fixups here tend to be more all over the map vs. some of the other
> repeated/systematic ones we've seen elsewhere.
>
> We remove module.h from code that isn't doing anything modular at
> all;  if they have __init sections, then replace it with init.h
>
> A couple drivers have module_exit() code that is essentially orphaned,
> and so we remove that.
>
> There are no module_init replacements, so we have no concerns wrt.
> initcall ordering changes as per some of the other cleanups.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> Cc: Tomasz Figa <tomasz.figa@...il.com>
> Cc: Thomas Abraham <thomas.ab@...sung.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-samsung-soc@...r.kernel.org
> Cc: linux-gpio@...r.kernel.org
> Acked-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Krzysztof is sub-submainter for the Samsung stuff in pinctrl so I
leave it to him to figure out how to bend, twist and merge this, then
I will get the result back from him with a pull request.

It looks good to me though.

Yours,
Linus Walleij