lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 May 2017 14:10:26 +1000 From: Michael Ellerman <mpe@...erman.id.au> To: paulmck@...ux.vnet.ibm.com, Stephen Rothwell <sfr@...b.auug.org.au> Cc: Linux-Next Mailing List <linux-next@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Joe Perches <joe@...ches.com>, Mike Frysinger <vapier@...too.org>, Steven Miao <realmz6@...il.com> Subject: Re: linux-next: build failure after merge of the rcu tree "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> writes: > On Mon, May 29, 2017 at 04:02:09PM +1000, Stephen Rothwell wrote: >> Hi Paul, >> >> After merging the rcu tree, today's linux-next build (bfin >> BF526-EZBRD_defconfig and several other bfin configs) failed like this: >> >> In file included from include/linux/srcu.h:60:0, >> from include/linux/notifier.h:15, >> from include/linux/memory_hotplug.h:6, >> from include/linux/mmzone.h:777, >> from include/linux/gfp.h:5, >> from include/linux/kmod.h:22, >> from include/linux/module.h:13, >> from include/linux/moduleloader.h:5, >> from arch/blackfin/kernel/module.c:9: >> include/linux/srcutiny.h: In function 'srcu_torture_stats_print': >> include/linux/srcutiny.h:96:2: error: 'mod' undeclared (first use in this function) >> >> Caused by commit >> >> 54ffb22bd841 ("rcutorture: Move SRCU status printing to SRCU implementations") > > And of course this is nothing but a printk(). Ah but it's not, it's a pr_alert(): + pr_alert("%s%s Tiny SRCU per-CPU(idx=%d): (%hd,%hd)\n", + tt, tf, idx, + READ_ONCE(sp->srcu_lock_nesting[!idx]), + READ_ONCE(sp->srcu_lock_nesting[idx])); Where pr_alert() is: #define pr_alert(fmt, ...) \ printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__) So that's where pr_fmt() is coming into it. And if any code in module.c called srcu_torture_stats_print(), it would actually claim to come from "module: ", which would be confusing. I don't think you use pr_fmt() in the RCU code, so you could skip using pr_alert() and just use printk(KERN_ALERT "...") and get the same result, without any interactions with pr_fmt(). cheers
Powered by blists - more mailing lists