linux-kernel - RE: [PATCH v2 1/1] intel_telemetry_debugfs: fix oops found while load/unload module test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 May 2017 22:30:55 +0000
From:   "Kushwaha, Priyalee" <priyalee.kushwaha@...el.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "dvhart@...radead.org" <dvhart@...radead.org>,
        "Chakravarty, Souvik K" <souvik.k.chakravarty@...el.com>,
        Andy Shevchenko <andy@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Platform Driver" <platform-driver-x86@...r.kernel.org>
Subject: RE: [PATCH v2 1/1] intel_telemetry_debugfs: fix oops found while
 load/unload module test

I noticed that both register_pm_notifier and unregister_pm_notifier() has no-op defined already for !CONFIG_PM_SLEEP. So don’t need to check flag anywhere. 
Thanks for feedback.


-----Original Message-----
From: Andy Shevchenko [mailto:andy.shevchenko@...il.com] 
Sent: Wednesday, May 31, 2017 3:13 PM
To: Kushwaha, Priyalee <priyalee.kushwaha@...el.com>
Cc: dvhart@...radead.org; Chakravarty, Souvik K <souvik.k.chakravarty@...el.com>; Andy Shevchenko <andy@...radead.org>; linux-kernel@...r.kernel.org; Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] intel_telemetry_debugfs: fix oops found while load/unload module test

On Fri, Jun 2, 2017 at 12:33 AM,  <priyalee.kushwaha@...el.com> wrote:
> This fix oops found while testing load/unload test of 
> intel_telemetry_debugfs module. Module_init uses register_pm_notifier 
> for PM callbacks, but unregister_pm_notifier was missing from 
> module_exit.

> +#ifdef CONFIG_PM_SLEEP
> +       unregister_pm_notifier(&pm_notifier);
> +#endif /* CONFIG_PM_SLEEP */

Neither here

> +#ifdef CONFIG_PM_SLEEP
> +       unregister_pm_notifier(&pm_notifier);
> +#endif /* CONFIG_PM_SLEEP */

Not there.

AFAIU we discussed to make unregister_pm_notifier() having stubs for !PM_SLEEP.

--
With Best Regards,
Andy Shevchenko