linux-kernel - Re: [PATCH 1/7] HID: hiddev: use hid_hw_open/close instead of usbhid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Jun 2017 10:22:21 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     kbuild-all@...org, Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] HID: hiddev: use hid_hw_open/close instead of
 usbhid_open/close

Hi Dmitry,

[auto build test WARNING on hid/for-next]
[also build test WARNING on v4.12-rc3 next-20170531]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/HID-Consolidate-serializing-ope-close-in-transport-drivers/20170601-092350
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-next
config: x86_64-randconfig-x016-201722 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/hid/usbhid/hiddev.c: In function 'hiddev_open':
>> drivers/hid/usbhid/hiddev.c:309:4: warning: ignoring return value of 'hid_hw_open', declared with attribute warn_unused_result [-Wunused-result]
       hid_hw_open(hid);
       ^~~~~~~~~~~~~~~~

vim +/hid_hw_open +309 drivers/hid/usbhid/hiddev.c

   293			goto bail;
   294		}
   295	
   296		spin_lock_irq(&list->hiddev->list_lock);
   297		list_add_tail(&list->node, &hiddev->list);
   298		spin_unlock_irq(&list->hiddev->list_lock);
   299	
   300		mutex_lock(&hiddev->existancelock);
   301		if (!list->hiddev->open++)
   302			if (list->hiddev->exist) {
   303				struct hid_device *hid = hiddev->hid;
   304				res = usbhid_get_power(hid);
   305				if (res < 0) {
   306					res = -EIO;
   307					goto bail_unlock;
   308				}
 > 309				hid_hw_open(hid);
   310			}
   311		mutex_unlock(&hiddev->existancelock);
   312		return 0;
   313	bail_unlock:
   314		mutex_unlock(&hiddev->existancelock);
   315	bail:
   316		file->private_data = NULL;
   317		vfree(list);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (24500 bytes)