linux-kernel - Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Jun 2017 14:09:47 +1000
From:   "Tobin C. Harding" <me@...in.cc>
To:     Greg KH <greg@...ah.com>
Cc:     linux-wireless@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>,
        Tycho Andersen <tycho@...ho.ws>,
        driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory

On Thu, Jun 01, 2017 at 12:45:37PM +0900, Greg KH wrote:
> On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote:
> > Current driver implements the WEXT interface. WEXT is in maintenance
> > mode, we need to re-write the driver using cfg80211. The current
> > driver is handy as a reference for the new implementation, we can keep
> > it in tree for now.
> > 
> > Move WEXT driver to sub directory, add dummy Makefile and Kconfig so
> > build completes successfully but does not process any files from the
> > WEXT directory.
> > 
> > Signed-off-by: Tobin C. Harding <me@...in.cc>
> > ---
> >  drivers/staging/ks7010/Kconfig              |    6 +-
> >  drivers/staging/ks7010/Makefile             |    3 -
> >  drivers/staging/ks7010/TODO                 |   36 -
> >  drivers/staging/ks7010/eap_packet.h         |  144 --
> >  drivers/staging/ks7010/ks7010_sdio.c        | 1079 ----------
> >  drivers/staging/ks7010/ks7010_sdio.h        |  164 --
> >  drivers/staging/ks7010/ks_hostif.c          | 2638 -----------------------
> >  drivers/staging/ks7010/ks_hostif.h          |  685 ------
> >  drivers/staging/ks7010/ks_wlan.h            |  514 -----
> >  drivers/staging/ks7010/ks_wlan_ioctl.h      |   67 -
> >  drivers/staging/ks7010/ks_wlan_net.c        | 2999 ---------------------------
> >  drivers/staging/ks7010/michael_mic.c        |  148 --
> >  drivers/staging/ks7010/michael_mic.h        |   25 -
> >  drivers/staging/ks7010/wext/Kconfig         |   10 +
> >  drivers/staging/ks7010/wext/Makefile        |    4 +
> >  drivers/staging/ks7010/wext/TODO            |   36 +
> >  drivers/staging/ks7010/wext/eap_packet.h    |  144 ++
> >  drivers/staging/ks7010/wext/ks7010_sdio.c   | 1079 ++++++++++
> >  drivers/staging/ks7010/wext/ks7010_sdio.h   |  164 ++
> >  drivers/staging/ks7010/wext/ks_hostif.c     | 2638 +++++++++++++++++++++++
> >  drivers/staging/ks7010/wext/ks_hostif.h     |  685 ++++++
> >  drivers/staging/ks7010/wext/ks_wlan.h       |  514 +++++
> >  drivers/staging/ks7010/wext/ks_wlan_ioctl.h |   67 +
> >  drivers/staging/ks7010/wext/ks_wlan_net.c   | 2999 +++++++++++++++++++++++++++
> >  drivers/staging/ks7010/wext/michael_mic.c   |  148 ++
> >  drivers/staging/ks7010/wext/michael_mic.h   |   25 +
> >  26 files changed, 8514 insertions(+), 8507 deletions(-)
> >  delete mode 100644 drivers/staging/ks7010/TODO
> >  delete mode 100644 drivers/staging/ks7010/eap_packet.h
> >  delete mode 100644 drivers/staging/ks7010/ks7010_sdio.c
> >  delete mode 100644 drivers/staging/ks7010/ks7010_sdio.h
> >  delete mode 100644 drivers/staging/ks7010/ks_hostif.c
> >  delete mode 100644 drivers/staging/ks7010/ks_hostif.h
> >  delete mode 100644 drivers/staging/ks7010/ks_wlan.h
> >  delete mode 100644 drivers/staging/ks7010/ks_wlan_ioctl.h
> >  delete mode 100644 drivers/staging/ks7010/ks_wlan_net.c
> >  delete mode 100644 drivers/staging/ks7010/michael_mic.c
> >  delete mode 100644 drivers/staging/ks7010/michael_mic.h
> >  create mode 100644 drivers/staging/ks7010/wext/Kconfig
> >  create mode 100644 drivers/staging/ks7010/wext/Makefile
> >  create mode 100644 drivers/staging/ks7010/wext/TODO
> >  create mode 100644 drivers/staging/ks7010/wext/eap_packet.h
> >  create mode 100644 drivers/staging/ks7010/wext/ks7010_sdio.c
> >  create mode 100644 drivers/staging/ks7010/wext/ks7010_sdio.h
> >  create mode 100644 drivers/staging/ks7010/wext/ks_hostif.c
> >  create mode 100644 drivers/staging/ks7010/wext/ks_hostif.h
> >  create mode 100644 drivers/staging/ks7010/wext/ks_wlan.h
> >  create mode 100644 drivers/staging/ks7010/wext/ks_wlan_ioctl.h
> >  create mode 100644 drivers/staging/ks7010/wext/ks_wlan_net.c
> >  create mode 100644 drivers/staging/ks7010/wext/michael_mic.c
> >  create mode 100644 drivers/staging/ks7010/wext/michael_mic.h
> 
> Please use the -M option to 'git format-patch" so that we can just see
> file moves, not delete/add like you have here.

Point noted, will submit v2 using -M option. This is the second time
you have told me this, that means I have to buy you a beer doesn't it?

Will follow the 'wait a day before submitting next version' rule.

thanks,
Tobin.