linux-kernel - Re: [PATCH v3 3/5] clk: qcom: ipq8074: Add Global Clock Controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Jun 2017 15:52:31 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Varadarajan Narayanan <varada@...eaurora.org>
Cc:     robh+dt@...nel.org, mark.rutland@....com, mturquette@...libre.com,
        linus.walleij@...aro.org, andy.gross@...aro.org,
        david.brown@...aro.org, catalin.marinas@....com,
        will.deacon@....com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        absahu@...eaurora.org, sjaganat@...eaurora.org,
        sricharan@...eaurora.org, mraghava@...eaurora.org
Subject: Re: [PATCH v3 3/5] clk: qcom: ipq8074: Add Global Clock Controller
 support

On 06/01, Varadarajan Narayanan wrote:
> From: Abhishek Sahu <absahu@...eaurora.org>
> 
> This patch adds support for the global clock controller found on
> the IPQ8074 based devices. This includes UART, I2C, SPI etc.
> 
> Signed-off-by: Abhishek Sahu <absahu@...eaurora.org>
> Signed-off-by: Varadarajan Narayanan <varada@...eaurora.org>
> ---
>  .../devicetree/bindings/clock/qcom,gcc.txt         |    1 +
>  drivers/clk/qcom/Kconfig                           |    9 +
>  drivers/clk/qcom/Makefile                          |    1 +
>  drivers/clk/qcom/gcc-ipq8074.c                     | 1009 ++++++++++++++++++++
>  include/dt-bindings/clock/qcom,gcc-ipq8074.h       |  152 +++

The new world order is to split these includes from the driver
changes. Then someone (clk or arm-soc related maintainers) can
merge that #define change somewhere stable and then apply the
driver code on top or the dts file on top.

So can you please split the header file off into it's own patch
before this one and resend?

> diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> new file mode 100644
> index 0000000..b62db77
> --- /dev/null
> +++ b/drivers/clk/qcom/gcc-ipq8074.c
> +
> +static int gcc_ipq8074_probe(struct platform_device *pdev)
> +{
> +	int ret, i;
> +
> +	for (i = 0; i < ARRAY_SIZE(gcc_ipq8074_hws); i++) {
> +		ret = devm_clk_hw_register(&pdev->dev, gcc_ipq8074_hws[i]);
> +		if (ret)
> +			return ret;
> +	}
> +
> +	ret = qcom_cc_probe(pdev, &gcc_ipq8074_desc);
> +
> +	return ret;

Just return qcom_cc_probe() please.

> +}
> +
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project