linux-kernel - Re: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Jun 2017 17:41:26 +0900
From:   Greg KH <gregkh@...uxfoundation.org>
To:     laurentiu.tudor@....com
Cc:     stuyoder@...il.com, devel@...verdev.osuosl.org, arnd@...db.de,
        roy.pledge@....com, linux-kernel@...r.kernel.org, agraf@...e.de,
        catalin.horghidan@....com, ioana.ciornei@....com,
        leoyang.li@....com, bharat.bhushan@....com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tudor@....com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@....com>
> 
> Several macros didn't had macro params enclosed
> in parens. Fix them to avoid precedence issues.
> 
> Found with checkpatch.pl who was issuing this
> message:
>   "Macro argument 'id' may be better as '(id)'
>    to avoid precedence issues"

Why are you line-wrapping at such a small number?  Please use 72 columns
like git asks you to...

thanks,

greg k-h