linux-kernel - [PATCH 2/9] mfd: tps65218: Remove redundant i2c_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Jun 2017 14:48:37 +0530
From:   Keerthy <j-keerthy@...com>
To:     <tony@...mide.com>, <milo.kim@...com>, <lee.jones@...aro.org>
CC:     <j-keerthy@...com>, <linux-omap@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH 2/9] mfd: tps65218: Remove redundant i2c_device_id

With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.

Signed-off-by: Keerthy <j-keerthy@...com>
---

Boot tested on am347x-gp-evm and checked for regulator registrations.

 drivers/mfd/tps65218.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
index 13834a0..53df80b 100644
--- a/drivers/mfd/tps65218.c
+++ b/drivers/mfd/tps65218.c
@@ -211,8 +211,7 @@ int tps65218_clear_bits(struct tps65218 *tps, unsigned int reg,
 };
 MODULE_DEVICE_TABLE(of, of_tps65218_match_table);
 
-static int tps65218_probe(struct i2c_client *client,
-				const struct i2c_device_id *ids)
+static int tps65218_probe(struct i2c_client *client)
 {
 	struct tps65218 *tps;
 	const struct of_device_id *match;
@@ -281,20 +280,22 @@ static int tps65218_remove(struct i2c_client *client)
 	return 0;
 }
 
+#if 0
 static const struct i2c_device_id tps65218_id_table[] = {
 	{ "tps65218", TPS65218 },
 	{ },
 };
 MODULE_DEVICE_TABLE(i2c, tps65218_id_table);
+#endif
 
 static struct i2c_driver tps65218_driver = {
 	.driver		= {
 		.name	= "tps65218",
 		.of_match_table = of_tps65218_match_table,
 	},
-	.probe		= tps65218_probe,
+	.probe_new	= tps65218_probe,
 	.remove		= tps65218_remove,
-	.id_table       = tps65218_id_table,
+	//.id_table       = tps65218_id_table,
 };
 
 module_i2c_driver(tps65218_driver);
-- 
1.9.1