[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 6 Jun 2017 15:31:22 -0700
From: Andy Lutomirski <luto@...capital.net>
To: Andy Lutomirski <luto@...nel.org>
Cc: Pali Rohár <pali.rohar@...il.com>,
platform-driver-x86@...r.kernel.org,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Mario Limonciello <mario_limonciello@...l.com>,
Rafael Wysocki <rjw@...ysocki.net>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Linux ACPI <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded
Binary WMI MOF metadata
On Mon, Jun 5, 2017 at 8:16 PM, Andy Lutomirski <luto@...nel.org> wrote:
> +static ssize_t
> +read_bmof(struct file *filp, struct kobject *kobj,
> + struct bin_attribute *attr,
> + char *buf, loff_t off, size_t count)
> +{
> + struct bmof_priv *priv =
> + container_of(attr, struct bmof_priv, bmof_bin_attr);
> +
> + if (off >= priv->bmofdata->buffer.length)
> + return 0;
> +
> + if (count > priv->bmofdata->buffer.length - off)
> + count = priv->bmofdata->buffer.length - off;
> +
> + memcpy(buf, priv->bmofdata->buffer.pointer + off, count);
> + return count;
> +}
I just discovered simple_read_from_buffer(). I think this whole
function could be:
struct bmof_priv *priv = ...;
return simple_read_from_buffer(buf, count, &off,
priv->bmofdata->buffer.pointer, priv->bmofdata->buffer.length);
--Andy
Powered by blists - more mailing lists