[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 07 Jun 2017 09:04:41 +1000
From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org
Cc: Paul Mackerras <paulus@...ba.org>,
Michael Ellerman <mpe@...erman.id.au>,
Vineet Gupta <vgupta@...opsys.com>,
Bart Van Assche <bart.vanassche@...disk.com>,
Robin Murphy <robin.murphy@....com>,
Joerg Roedel <jroedel@...e.de>,
Johan Hovold <johan@...nel.org>,
Alexey Kardashevskiy <aik@...abs.ru>,
Krzysztof Kozlowski <krzk@...nel.org>,
linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs
for bus_type
On Tue, 2017-06-06 at 21:30 +0200, Greg Kroah-Hartman wrote:
> >
> > static struct device_attribute vio_dev_attrs[] = {
> > __ATTR_RO(name),
> > @@ -1573,6 +1576,13 @@ static struct device_attribute vio_dev_attrs[] = {
> > __ATTR_RO(modalias),
> > __ATTR_NULL
> > };
> > +static struct attribute *vio_dev_attrs[] = {
>
> Hm, this feels wrong, odd that 0-day passed it. I should be deleting
> the above vio_dev_attrs field as well. Is powerpc really a dead
> platform? :)
Haha, not yet no, and the above is actually still quite actively
in use as it's part of our hypervisor virtual IO infrastructure.
Cheers,
Ben.
Powered by blists - more mailing lists