linux-kernel - Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170606144909.GA31938@kroah.com>
Date:   Tue, 6 Jun 2017 16:49:09 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     David Kershner <david.kershner@...sys.com>
Cc:     corbet@....net, tglx@...utronix.de, mingo@...nel.org,
        akpm@...ux-foundation.org, jes.sorensen@...il.com,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org, sparmaintainer@...sys.com
Subject: Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote:
> This patchset moves drivers/staging/unisys/include to
> include/linux/visorbus, and moves drivers/staging/unisys/visorbus to
> drivers/virt/visorbus.

Um, are you thinking it is ready to be moved?  Have you asked for
another review?

In a totally random chance, I was doing some driver core work today and
I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you
have 2 tabs for your 'struct attribute' variables, which is really odd.

Also, you should be using the ATTRIBUTE_GROUPS() macro for them instead
of having to "open code" the struct attribute_group lists.

So either you all have horrible luck in that I just happened to find the
only remaining problem, or that you should proabably ask for a good code
audit, I haven't looked at the code before today since the last round of
"fun" I found in just one other random file :)

thanks,

greg k-h