linux-kernel - Re: [PATCH v2 2/8] HID: hiddev: use hid_hw_power instead of usbhid_get/put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Jun 2017 11:40:17 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2 2/8] HID: hiddev: use hid_hw_power instead of usbhid_get/put_power

On Wed, Jun 7, 2017 at 9:59 AM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> Instead of calling into usbhid code directly, let's use the standard
> accessors for the transport HID drivers, and stop clobbering their error
> codes with -EIO.
>
> This also allows us to remove usbhid_get/put_power(), leaving only
> usbhid_power().

>                 break;
> +
>         case PM_HINT_NORMAL:

>         }
> +
>         return r;

I think you can drop above changes.

-- 
With Best Regards,
Andy Shevchenko