linux-kernel - Re: [PATCH tip/core/rcu 0/88] Commits for 4.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Jun 2017 09:52:10 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...nel.org,
        jiangshanlai@...il.com, dipankar@...ibm.com,
        akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
        josh@...htriplett.org, tglx@...utronix.de, peterz@...radead.org,
        dhowells@...hat.com, edumazet@...gle.com, fweisbec@...il.com,
        oleg@...hat.com, bobby.prani@...il.com
Subject: Re: [PATCH tip/core/rcu 0/88] Commits for 4.13

On Thu, 25 May 2017 14:59:34 -0700
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> wrote:

> Hello!
> 
> This rather long series mostly removes unused features, shrinks the
> include/linux/rcupdate.h file's .i intermediate-output size, updates
> rcutorture testing, and supplies miscellaneous fixes.  Branching proved
> impractical due to the large footprint of many of the commits, hence the
> long linear series.  On the other hand, this series's diffstat summary
> line is as follows:
> 
>  87 files changed, 1745 insertions(+), 4389 deletions(-)
>

Hi Paul,

88 patches is quite overwhelming. I would recommend breaking something
like this up into multiple patch series with different topics. One
could be the ones that affect seftests only. Another for srcu, another
for documentation, etc.

When one gets 88 patches and sees that it's a hodge podge of various
parts of RCU, they tend to just ignore the entire series. If you want
reviewers, I strongly recommend breaking it down nicer so that those
that are interested in only parts of RCU will be more likely to review
the patches. Otherwise, people will just say "I don't have time to sort
through all this to find what I'm interested in reviewing", and skip
the entire series.

Thanks!

-- Steve