linux-kernel - Re: [PATCH] drm: Use vsnprintf extension %ph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 11 Jun 2017 16:52:04 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Sean Paul <seanpaul@...omium.org>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: Use vsnprintf extension %ph

On Sun, Jun 11, 2017 at 3:20 AM, Joe Perches <joe@...ches.com> wrote:
> On Sat, 2017-06-10 at 19:12 +0300, Andy Shevchenko wrote:
>> On Wed, May 31, 2017 at 2:35 AM, Joe Perches <joe@...ches.com> wrote:
>> > Using the extension saves a bit of code.
>> > +               seq_printf(m, "faux/mst: %*ph\n", 2, buf);
>> > +               seq_printf(m, "mst ctrl: %*ph\n", 1, buf);
>> > +               seq_printf(m, "branch oui: %*phN devid: ", 3, buf);
>>
>> All above may use shorter form, i.e.
>> "..., "%Xph", buf);", where X is a constant written explicitly inplace.
>
> I know.  Consistency is better though.
> Note the use of DP_RECEIVER_CAP_SIZE, etc...

Fair enough.

-- 
With Best Regards,
Andy Shevchenko