linux-kernel - Re: [PATCH v2 1/2] tcp: md5: add an address prefix for key lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2017 09:20:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ivan Delalande <colona@...sta.com>
Cc:     kbuild-all@...org, David Miller <davem@...emloft.net>,
        Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Ivan Delalande <colona@...sta.com>
Subject: Re: [PATCH v2 1/2] tcp: md5: add an address prefix for key lookup

Hi Ivan,

[auto build test WARNING on net/master]
[also build test WARNING on v4.12-rc4 next-20170609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ivan-Delalande/tcp-md5-add-an-address-prefix-for-key-lookup/20170611-184237
config: x86_64-randconfig-s2-06120830 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   net//ipv4/tcp_ipv4.c: In function 'tcp_md5_do_lookup':
>> net//ipv4/tcp_ipv4.c:908: warning: unused variable 'size'

vim +/size +908 net//ipv4/tcp_ipv4.c

^1da177e4 Linus Torvalds       2005-04-16  892  }
^1da177e4 Linus Torvalds       2005-04-16  893  
cfb6eeb4c YOSHIFUJI Hideaki    2006-11-14  894  #ifdef CONFIG_TCP_MD5SIG
cfb6eeb4c YOSHIFUJI Hideaki    2006-11-14  895  /*
cfb6eeb4c YOSHIFUJI Hideaki    2006-11-14  896   * RFC2385 MD5 checksumming requires a mapping of
cfb6eeb4c YOSHIFUJI Hideaki    2006-11-14  897   * IP address->MD5 Key.
cfb6eeb4c YOSHIFUJI Hideaki    2006-11-14  898   * We need to maintain these in the sk structure.
cfb6eeb4c YOSHIFUJI Hideaki    2006-11-14  899   */
cfb6eeb4c YOSHIFUJI Hideaki    2006-11-14  900  
cfb6eeb4c YOSHIFUJI Hideaki    2006-11-14  901  /* Find the Key structure for an address.  */
b83e3deb9 Eric Dumazet         2015-09-25  902  struct tcp_md5sig_key *tcp_md5_do_lookup(const struct sock *sk,
a915da9b6 Eric Dumazet         2012-01-31  903  					 const union tcp_md5_addr *addr,
a915da9b6 Eric Dumazet         2012-01-31  904  					 int family)
cfb6eeb4c YOSHIFUJI Hideaki    2006-11-14  905  {
fd3a154a0 Eric Dumazet         2015-03-24  906  	const struct tcp_sock *tp = tcp_sk(sk);
a915da9b6 Eric Dumazet         2012-01-31  907  	struct tcp_md5sig_key *key;
a915da9b6 Eric Dumazet         2012-01-31 @908  	unsigned int size = sizeof(struct in_addr);
fd3a154a0 Eric Dumazet         2015-03-24  909  	const struct tcp_md5sig_info *md5sig;
4b9e1d2ec Ivan Delalande       2017-06-09  910  	__be32 mask;
4b9e1d2ec Ivan Delalande       2017-06-09  911  	struct tcp_md5sig_key *best_match = NULL;
4b9e1d2ec Ivan Delalande       2017-06-09  912  	bool match;
cfb6eeb4c YOSHIFUJI Hideaki    2006-11-14  913  
a8afca032 Eric Dumazet         2012-01-31  914  	/* caller either holds rcu_read_lock() or socket lock */
a8afca032 Eric Dumazet         2012-01-31  915  	md5sig = rcu_dereference_check(tp->md5sig_info,
1e1d04e67 Hannes Frederic Sowa 2016-04-05  916  				       lockdep_sock_is_held(sk));

:::::: The code at line 908 was first introduced by commit
:::::: a915da9b69273815527ccb3789421cb7027b545b tcp: md5: rcu conversion

:::::: TO: Eric Dumazet <eric.dumazet@...il.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29973 bytes)