linux-kernel - Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jun 2017 09:17:54 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     linux-kernel@...r.kernel.org, briannorris@...omium.org,
        dtor@...omium.org, dianders@...omium.org
Subject: Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove

mfd: cros_ec: Add missing free_irq in cros_ec_remove

It would be better to use more English and less code in the patch's
subject line.  Something like "Clean-up IRQ on unbind" Or "Free IRQ on
exit".  Something of that nature.

Also, you should populate the commit log with what are you doing and
why is it required.

> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
> 
> ---
> 
>  drivers/mfd/cros_ec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index e31ac60..dc6ce90 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev)
>  
>  	cros_ec_acpi_remove_gpe_handler();
>  
> +	if (ec_dev->irq)
> +		free_irq(ec_dev->irq, ec_dev);
> +
>  	return 0;
>  }
>  EXPORT_SYMBOL(cros_ec_remove);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog