lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Jun 2017 12:01:55 +0900 From: "Takiguchi, Yasunari" <Yasunari.Takiguchi@...y.com> To: Mauro Carvalho Chehab <mchehab@...pensource.com> CC: "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, "tbird20d@...il.com" <tbird20d@...il.com>, "frowand.list@...il.com" <frowand.list@...il.com>, "Yamamoto, Masayuki" <Masayuki.Yamamoto@...y.com>, "Nozawa, Hideki (STWN)" <Hideki.Nozawa@...y.com>, "Yonezawa, Kota" <Kota.Yonezawa@...y.com>, "Matsumoto, Toshihiko" <Toshihiko.Matsumoto@...y.com>, "Watanabe, Satoshi (SSS)" <Satoshi.C.Watanabe@...y.com>, <yasunari.takiguchi@...y.com> Subject: Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator Dear Mauro Thanks for your kind review during your busy schedule. I will confirm with your findings and discuss about them (how to change our codes) in our team. Regards & Thanks Takiguchi On 2017/06/13 23:38, Mauro Carvalho Chehab wrote: > Hi Takiguchi-san, > > Em Thu, 25 May 2017 15:15:39 +0900 > "Takiguchi, Yasunari" <Yasunari.Takiguchi@...y.com> escreveu: > >> Hi, all >> >> I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver on Apr/14. >> Are there any comments, advices and review results for them? > > Usually, reviewing drivers takes more time, as one needs to reserve a > long period of time for reviewing. Sorry for the delay. > >> I'd like to get better understanding of current review status for our codes. > > Just sent today a review. There are some things that need to be > changed in order to get it into a better shape and make it easier > to review. In particular, it should be using some Kernel internal APIs, > instead of coming with re-implementation of existing core code. That's fine. > It is very unusual that the first contributions from a new Kernel > developer to gets everything the way as it is expected mainstream ;-) > > One thing that come into my mind, besides what was already commented, > is that it seems you added an abstraction layer. We don't like such > layers very much, as it makes harder to understand the driver, usually > for very little benefit. > > On this first review, I didn't actually try to understand what's > going on there. As the driver doesn't contain any comments inside, > it makes harder to understand why some things were coded using > such approach. > > Thanks, > Mauro
Powered by blists - more mailing lists