lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 Jun 2017 17:37:50 -0700 From: Joe Perches <joe@...ches.com> To: Andy Shevchenko <andy.shevchenko@...il.com>, Okash Khawaja <okash.khawaja@...il.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.com>, Samuel Thibault <samuel.thibault@...-lyon.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, William Hubbs <w.d.hubbs@...il.com>, Chris Brannon <chris@...-brannons.com>, Kirk Reiser <kirk@...sers.ca>, speakup@...ux-speakup.org, devel@...verdev.osuosl.org Subject: Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t On Sun, 2017-06-18 at 22:54 +0300, Andy Shevchenko wrote: > On Sun, Jun 18, 2017 at 8:22 PM, Okash Khawaja <okash.khawaja@...il.com> wrote: > > On Sun, Jun 18, 2017 at 04:35:21PM +0300, Andy Shevchenko wrote: > > > > + if (ser < 0 || ser > (255 - 64)) { > > > > + pr_err("speakup: Invalid ser param. \ > > > > + Must be between 0 and 191 inclusive.\n"); > > > > > > Just make it one line. > > > > Is it okay if it becomes larger than 80 chars? > > Yes. Even checkpatch will not complain in this case. And even if it didn't, as written it's a defect because line continuations don't act like string concatenations. You've added a space before the line continuation \ and a bunch of whitespace before the word Must
Powered by blists - more mailing lists