lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Jun 2017 08:09:10 +0800 From: Leo Yan <leo.yan@...aro.org> To: Stephen Boyd <sboyd@...eaurora.org> Cc: Wei Xu <xuwei5@...ilicon.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Michael Turquette <mturquette@...libre.com>, Zhangfei Gao <zhangfei.gao@...aro.org>, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, Guodong Xu <guodong.xu@...aro.org>, Haojian Zhuang <haojian.zhuang@...aro.org> Subject: Re: [PATCH v3 1/2] clk: Hi3660: register fixed_rate_clks with CLK_OF_DECLARE_DRIVER On Mon, Jun 19, 2017 at 04:36:55PM -0700, Stephen Boyd wrote: > On 05/22, Leo Yan wrote: > > The timer will register into system at very early phase at kernel boot; > > if timer needs to use clock, the clock should be get ready in function > > of_clk_init() so later the timer driver probe can retrieve clock > > successfully. This is finished in below flow on arm64: > > > > start_kernel() > > `-> time_init() > > `-> of_clk_init(NULL) => register timer's clock > > `-> clocksource_probe() => register timer > > > > On Hi3660 the sp804 timer uses clock "osc32k", this clock is registered > > as platform driver rather than CLK_OF_DECLARE_DRIVER method. As result, > > sp804 timer probe returns failure due if cannot bind clock properly. > > > > To fix the failure, this patch is to split crgctrl clocks into two > > subsets. One part is for fixed_rate_clks which includes pre-defined > > fixed rate clocks, and "osc32k" clock is in this category; So we change > > their registration to CLK_OF_DECLARE_DRIVER method, as result the clocks > > can be registered ahead with function of_clk_init() and timer driver can > > bind timer clock successfully; the rest of the crgctrl clocks are still > > registered by the probe of the platform driver. > > > > This patch also adds checking for all crgctrl clocks registration and > > print out log if any clock has failure. > > > > Signed-off-by: Leo Yan <leo.yan@...aro.org> > > --- > > Applied to clk-next Thanks! > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project
Powered by blists - more mailing lists