linux-kernel - Re: [PATCH] rcu: remove unused variable in boot_cpu_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2017 00:15:50 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rcu: remove unused variable in boot_cpu_state_init

On Thu, Jun 22, 2017 at 12:10 AM, Paul E. McKenney
<paulmck@...ux.vnet.ibm.com> wrote:
> On Wed, Jun 21, 2017 at 11:57:28PM +0200, Arnd Bergmann wrote:
>> Without CONFIG_SMP, we get a harmless warning about
>> an unused variable:
>>
>> kernel/cpu.c: In function 'boot_cpu_state_init':
>> kernel/cpu.c:1778:6: error: unused variable 'cpu' [-Werror=unused-variable]
>>
>> This reworks the function to have the declaration inside
>> of the #ifdef.
>>
>> Fixes: faeb334286b7 ("rcu: Migrate callbacks earlier in the CPU-offline timeline")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> I simply added a __maybe_unused in 6441c656acde ("rcu: Migrate callbacks
> earlier in the CPU-offline timeline") in my -rcu tree.  However, your
> approach does have the advantage of complaining if the code using that
> variable is removed.
>
> So, would you be OK with my folding your approach into my commit with
> attribution?

Sure, that's always best.

      Arnd