linux-kernel - Re: [PATCH 2/4] drm/vc4: Wait for fences interruptibly in blocking mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2017 09:22:49 +0200
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Eric Anholt <eric@...olt.net>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] drm/vc4: Wait for fences interruptibly in blocking
 mode.

On Wed, 21 Jun 2017 11:50:00 -0700
Eric Anholt <eric@...olt.net> wrote:

> We should allow SIGIO and things to interrupt us before we get to the
> no-error stage of the commit process.  This code is effectively copied
> from drm_atomic_helper_commit().
> 
> Signed-off-by: Eric Anholt <eric@...olt.net>

Reviewed-by: Boris Brezillon <boris.brezillon@...e-electrons.com>

> ---
>  drivers/gpu/drm/vc4/vc4_kms.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c
> index bc6ecdc6f104..6b1ccea76243 100644
> --- a/drivers/gpu/drm/vc4/vc4_kms.c
> +++ b/drivers/gpu/drm/vc4/vc4_kms.c
> @@ -142,6 +142,16 @@ static int vc4_atomic_commit(struct drm_device *dev,
>  		return ret;
>  	}
>  
> +	if (!nonblock) {
> +		ret = drm_atomic_helper_wait_for_fences(dev, state, true);
> +		if (ret) {
> +			drm_atomic_helper_cleanup_planes(dev, state);
> +			kfree(c);
> +			up(&vc4->async_modeset);
> +			return ret;
> +		}
> +	}
> +
>  	for_each_plane_in_state(state, plane, new_state, i) {
>  		if ((plane->state->fb != new_state->fb) && new_state->fb) {
>  			struct drm_gem_cma_object *cma_bo =