linux-kernel - Re: [PATCH] sparc64: Fix gup_huge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2017 20:53:57 +1000
From:   Julian Calaby <julian.calaby@...il.com>
To:     Nitin Gupta <nitin.m.gupta@...cle.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Lorenzo Stoakes <lstoakes@...il.com>, Jan Kara <jack@...e.cz>,
        Michal Hocko <mhocko@...e.com>,
        sparclinux <sparclinux@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sparc64: Fix gup_huge_pmd

Hi Nitin,

On Thu, Jun 22, 2017 at 7:50 AM, Nitin Gupta <nitin.m.gupta@...cle.com> wrote:
> The function assumes that each PMD points to head of a
> huge page. This is not correct as a PMD can point to
> start of any 8M region with a, say 256M, hugepage. The
> fix ensures that it points to the correct head of any PMD
> huge page.
>
> Signed-off-by: Nitin Gupta <nitin.m.gupta@...cle.com>
> ---
>  arch/sparc/mm/gup.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c
> index cd0e32b..9116a6f 100644
> --- a/arch/sparc/mm/gup.c
> +++ b/arch/sparc/mm/gup.c
> @@ -80,6 +80,8 @@ static int gup_huge_pmd(pmd_t *pmdp, pmd_t pmd, unsigned long addr,
>         refs = 0;
>         head = pmd_page(pmd);
>         page = head + ((addr & ~PMD_MASK) >> PAGE_SHIFT);
> +       if (PageTail(head))
> +               head = compound_head(head);

Stupid question: shouldn't this go before the page calculation?

>         do {
>                 VM_BUG_ON(compound_head(page) != head);
>                 pages[*nr] = page;

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/