linux-kernel - Re: [PATCH] docs/memory-hotplug: adjust the explanation of valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2017 20:21:14 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Wei Yang <richard.weiyang@...il.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs/memory-hotplug: adjust the explanation of
 valid_zones sysfs

On Thu 22-06-17 12:18:44, Wei Yang wrote:
[...]
> -'valid_zones'     : read-only: designed to show which zones this memory block
> -		    can be onlined to.
> -		    The first column shows it's default zone.
> +'valid_zones'     : read-only: shows different information based on state.
> +		    When state is online, it is designed to show the
> +		    zone name this memory block is onlined to.
> +		    When state is offline, it is designed to show which zones
> +		    this memory block can be onlined to.  The first column
> +		    shows it's default zone.

I do not think we really need to touch this. First of all the last
sentence is not really correct. The ordering of zones doesn't tell which
zone will be onlined by default. This is indeed a change of behavior of
my patch. I am just not sure anybody depends on that. I can fix it up
but again the old semantic was just awkward and I didn't feel like I
should keep it. Also I plan to change this behavior again with planned
patches. I would like to get rid of the non-overlapping zones
restriction so the wording would have to change again.

That being said, let's keep the wording as it is now.

Thanks!
-- 
Michal Hocko
SUSE Labs