linux-kernel - Re: [PATCH v2 2/2] x86/xen/efi: Init only efi struct members used by Xen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2017 15:25:28 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Daniel Kiper <daniel.kiper@...cle.com>, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        stable@...r.kernel.org, xen-devel@...ts.xenproject.org
Cc:     jgross@...e.com, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com, matt@...eblueprint.co.uk, ard.biesheuvel@...aro.org,
        andrew.cooper3@...rix.com
Subject: Re: [PATCH v2 2/2] x86/xen/efi: Init only efi struct members used by
 Xen

On 06/22/2017 06:51 AM, Daniel Kiper wrote:
> Current approach, wholesale efi struct initialization from efi_xen, is not
> good. Usually if new member is defined then it is properly initialized in
> drivers/firmware/efi/efi.c but not in arch/x86/xen/efi.c. As I saw it happened
> a few times until now. So, let's initialize only efi struct members used by
> Xen to avoid such issues in the future.
>
> Signed-off-by: Daniel Kiper <daniel.kiper@...cle.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>