linux-kernel - Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Jun 2017 14:46:34 +0000
From:   Philippe CORNU <philippe.cornu@...com>
To:     Eric Anholt <eric@...olt.net>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        Yannick FERTRE <yannick.fertre@...com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge
 support"



On 06/22/2017 07:56 PM, Eric Anholt wrote:
> Signed-off-by: Eric Anholt <eric@...olt.net>
> ---
> 
> This fixup would be squashed into patch 1 of your series.

Hi Eric,
and many thanks for the two patches, I will follow your suggestion for 
the v5 serie.
By the way, do you have more comments on the "drm/stm: ltdc: Add 
panel-bridge support" patch?
Many thanks :-)
Philippe

>   drivers/gpu/drm/stm/ltdc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7d7e889f09c3..d1d28348512b 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -953,7 +953,8 @@ int ltdc_load(struct drm_device *ddev)
>   		bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DPI);
>   		if (IS_ERR(bridge)) {
>   			DRM_ERROR("Failed to create panel-bridge\n");
> -			return PTR_ERR(bridge);
> +			ret = PTR_ERR(bridge);
> +			goto err;
>   		}
>   		ldev->is_panel_bridge = true;
>   	}
>