linux-kernel - Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using correct %zx printk format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 23 Jun 2017 19:21:30 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Brian Norris <computersforpeace@...il.com>
Cc:     Rafał Miłecki <rafal@...ecki.pl>,
        David Woodhouse <dwmw2@...radead.org>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        linux-mtd@...ts.infradead.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using
 correct %zx printk format specifier

On 23/06/17 19:15, Brian Norris wrote:
> On Fri, Jun 23, 2017 at 07:03:11PM +0100, Colin Ian King wrote:
>> On 23/06/17 18:51, Brian Norris wrote:
>>> On Fri, Jun 23, 2017 at 12:02:34PM +0200, Rafał Miłecki wrote:
>>>> On 2017-06-23 11:00, Colin King wrote:
>>>>> From: Colin Ian King <colin.king@...onical.com>
>>>>>
>>>>> Use %zx instead of %X for size_t variable offset, fixes build warning:
>>>>>
>>>>> warning: format '%X' expects argument of type 'unsigned int', but
>>>>> argument
>>>>> 2 has type 'size_t {aka long unsigned int}' [-Wformat=]
>>>>>
>>>>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>>>>
>>>> I sent similar patch few hours earlier:
>>>> [PATCH] mtd: parsers: trx: fix pr_err format for printing offset
>>>> https://patchwork.ozlabs.org/patch/779789/
>>>>
>>>> Brian: you may pick the one with nicer commit message, whichever one you
>>>> prefer :)
>>>
>>> I'll go with:
>>> (a) the earlier one and
>>> (b) the one that doesn't change 'X' to 'x'
>>>
>>> That means Rafał, you're our lucky winner today! Thanks for playing,
>>> Colin.
>>
>> FYI, I used %zx rather than %zX as couldn't find any instances of it in
>> the kernel and I wasn't 100% sure if it was supported or not.
> 
> 'x' and 'X' are handled nearly identically in lib/vsprintf.c. Don't see
> why it wouldn't be.
> 
>> linux-next:
>>
>> $ git grep "%zx" | wc -l
>> 161
>>
>> $ git grep "%zX" | wc -l
>> 0
> 
> Yay, we're unique!
> 
> Seriously though: I don't really care which one is used (though I guess
> I'm personally more used to lower-case hex). I just figured the less
> churn the better.

That's fine by me too.
> 
> Brian
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>