linux-kernel - Re: [PATCH v3 1/1] usb:host:xhci support option to disable the xHCI USB2 HW LPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Jun 2017 14:03:08 -0500
From:   Rob Herring <robh@...nel.org>
To:     "Thang Q. Nguyen" <tqnguyen@....com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Phong Vo <pvo@....com>,
        Loc Ho <lho@....com>, Tung Nguyen <tunguyen@....com>,
        patches@....com
Subject: Re: [PATCH v3 1/1] usb:host:xhci support option to disable the xHCI
 USB2 HW LPM

On Fri, Jun 23, 2017 at 10:02:12AM +0700, Thang Q. Nguyen wrote:
> XHCI specification 1.1 does not require xHCI-compliant controllers
> to always enable hardware USB2 LPM. However, the current xHCI
> driver always enable it when seeing HLC=1.
> This patch supports an option for users to control disabling
> USB2 Hardware LPM via DT/ACPI attribute.
> This option is needed in case user would like to disable this
> feature. For example, their xHCI controller has its USB2 HW LPM
> broken.
> 
> Signed-off-by: Tung Nguyen <tunguyen@....com>
> Signed-off-by: Thang Q. Nguyen <tqnguyen@....com>
> ---
> Changes since v2:
>  - Change code to disable HW LPM as an option for user which
>    is set via ACPI/DT.
> Changes since v1:
>  - Update DT/ACPI attribute and corresponding codes from HLE to LPM to
>    be consistent with other attribute names.
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt |    1 +
>  drivers/usb/host/xhci-plat.c                       |    3 +++
>  drivers/usb/host/xhci.c                            |    3 +++
>  drivers/usb/host/xhci.h                            |    1 +
>  4 files changed, 8 insertions(+), 0 deletions(-)

Acked-by: Rob Herring <robh@...nel.org>