linux-kernel - Re: [PATCH 1/3] [media] venus: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Jun 2017 22:41:52 +0300
From:   Stanimir Varbanov <svarbanov@...sol.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Hans Verkuil <hansverk@...co.com>,
        Colin Ian King <colin.king@...onical.com>,
        linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] [media] venus: mark PM functions as __maybe_unused

Hi Arnd,

Thanks for the catch!

On 27.06.2017 18:02, Arnd Bergmann wrote:
> Without PM support, gcc warns about two unused functions:
> 
> platform/qcom/venus/core.c:146:13: error: 'venus_clks_disable' defined but not used [-Werror=unused-function]
> platform/qcom/venus/core.c:126:12: error: 'venus_clks_enable' defined but not used [-Werror=unused-function]
> 
> The problem as usual are incorrect #ifdefs, so the easiest fix
> is to do away with the #ifdef completely and mark the suspend/resume
> handlers as __maybe_unused, which they are.
> 
> Fixes: af2c3834c8ca ("[media] media: venus: adding core part and helper functions")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Stanimir Varbanov <stanimir.varbanov@...aro.org>

> ---
>   drivers/media/platform/qcom/venus/core.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index d8cbe8549d97..47f79637938c 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -270,8 +270,7 @@ static int venus_remove(struct platform_device *pdev)
>   	return ret;
>   }
>   
> -#ifdef CONFIG_PM
> -static int venus_runtime_suspend(struct device *dev)
> +static __maybe_unused int venus_runtime_suspend(struct device *dev)
>   {
>   	struct venus_core *core = dev_get_drvdata(dev);
>   	int ret;
> @@ -283,7 +282,7 @@ static int venus_runtime_suspend(struct device *dev)
>   	return ret;
>   }
>   
> -static int venus_runtime_resume(struct device *dev)
> +static __maybe_unused int venus_runtime_resume(struct device *dev)
>   {
>   	struct venus_core *core = dev_get_drvdata(dev);
>   	int ret;
> @@ -302,7 +301,6 @@ static int venus_runtime_resume(struct device *dev)
>   	venus_clks_disable(core);
>   	return ret;
>   }
> -#endif
>   
>   static const struct dev_pm_ops venus_pm_ops = {
>   	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
>