linux-kernel - Re: [BUG] ftrace: WARNING: suspicious RCU usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Jun 2017 18:57:43 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [BUG] ftrace: WARNING: suspicious RCU usage

On Wed, 28 Jun 2017 07:52:22 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index e354e47..442b409 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -973,8 +973,10 @@ static void rcu_eqs_exit(bool user)
>  	if (oldval & DYNTICK_TASK_NEST_MASK) {
>  		rdtp->dynticks_nesting += DYNTICK_TASK_NEST_VALUE;
>  	} else {
> +		__this_cpu_inc(disable_rcu_irq_enter);
>  		rdtp->dynticks_nesting = DYNTICK_TASK_EXIT_IDLE;
>  		rcu_eqs_exit_common(oldval, user);
> +		__this_cpu_dec(disable_rcu_irq_enter);
>  	}
>  }
>  

Looks like a good fix to me. Paul want to take this one?

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve