linux-kernel - [PATCH v2 01/15] staging: fsl-mc: move comparison before strcmp() call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Jun 2017 17:41:21 +0300
From:   <laurentiu.tudor@....com>
To:     <gregkh@...uxfoundation.org>, <stuyoder@...il.com>
CC:     <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>,
        <marc.zyngier@....com>, <agraf@...e.de>, <arnd@...db.de>,
        <ioana.ciornei@....com>, <ruxandra.radulescu@....com>,
        <bharat.bhushan@....com>, <catalin.horghidan@....com>,
        <leoyang.li@....com>, <roy.pledge@....com>,
        <linux-arm-kernel@...ts.infradead.org>,
        Laurentiu Tudor <laurentiu.tudor@....com>
Subject: [PATCH v2 01/15] staging: fsl-mc: move comparison before strcmp() call

From: Laurentiu Tudor <laurentiu.tudor@....com>

Move comparison before the strcmp() in this if statement, and slightly
increase efficiency by not making the strcmp() each time the if gets
evaluated but only when the comparison is true.
This was suggested in a review comment.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@....com>
---
v2:
 - new patch

 drivers/staging/fsl-mc/bus/dprc-driver.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
index 80c080f..1765e2d 100644
--- a/drivers/staging/fsl-mc/bus/dprc-driver.c
+++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -29,8 +29,9 @@ struct dprc_child_objs {
 static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
 				struct dprc_obj_desc *obj_desc)
 {
-	return !strcmp(mc_dev->obj_desc.type, obj_desc->type) &&
-		mc_dev->obj_desc.id == obj_desc->id;
+	return mc_dev->obj_desc.id == obj_desc->id &&
+	       !strcmp(mc_dev->obj_desc.type, obj_desc->type);
+
 }
 
 static int __fsl_mc_device_remove_if_not_in_mc(struct device *dev, void *data)
-- 
2.9.4