linux-kernel - RE: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking jiffies.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Jun 2017 16:38:00 +0000
From:   Leo Li <leoyang.li@....com>
To:     Scott Wood <oss@...error.net>,
        Karim Eshapa <karim.eshapa@...il.com>
CC:     Roy Pledge <roy.pledge@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking
 jiffies.



> -----Original Message-----
> From: Scott Wood [mailto:oss@...error.net]
> Sent: Saturday, June 24, 2017 9:47 PM
> To: Karim Eshapa <karim.eshapa@...il.com>
> Cc: Roy Pledge <roy.pledge@....com>; linux-kernel@...r.kernel.org;
> Claudiu Manoil <claudiu.manoil@....com>; colin.king@...onical.com;
> linuxppc-dev@...ts.ozlabs.org; linux-arm-kernel@...ts.infradead.org; Leo Li
> <leoyang.li@....com>
> Subject: Re: [v3] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck
> hacking jiffies.
> 
> On Fri, May 05, 2017 at 07:45:18AM +0200, Karim Eshapa wrote:
> > Use msleep() instead of stucking with
> > long delay will be more efficient.
> >
> > Signed-off-by: Karim Eshapa <karim.eshapa@...il.com>
> > ---
> >  drivers/soc/fsl/qbman/qman.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> Acked-by: Scott Wood <oss@...error.net>
> 
> (though the subject line should be "soc/qman: ...")
> 
> Leo, are you going to send this patch (and other qman patches) via arm-soc?

Yes.  I can take it through the pull request for soc/fsl via arm-soc.  As mentioned in the feedback from David in another email, probably we should update the comment and commit message to mention how 10000 cycles becomes 1ms.

Regards,
Leo