linux-kernel - Re: [PATCH] mm/memory_hotplug: remove an unused variable in move_pfn_range_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Jun 2017 10:26:38 +0530
From:   Anshuman Khandual <khandual@...ux.vnet.ibm.com>
To:     Wei Yang <richard.weiyang@...il.com>, mhocko@...nel.org,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/memory_hotplug: remove an unused variable in
 move_pfn_range_to_zone()

On 06/27/2017 04:49 AM, Wei Yang wrote:
> There is an unused variable in move_pfn_range_to_zone().
> 
> This patch just removes it.
> 
> Signed-off-by: Wei Yang <richard.weiyang@...il.com>
> ---
>  mm/memory_hotplug.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 514014dde16b..16167c92bbf1 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -899,7 +899,6 @@ void __ref move_pfn_range_to_zone(struct zone *zone,
>  	struct pglist_data *pgdat = zone->zone_pgdat;
>  	int nid = pgdat->node_id;
>  	unsigned long flags;
> -	unsigned long i;
>  
>  	if (zone_is_empty(zone))
>  		init_currently_empty_zone(zone, start_pfn, nr_pages);

We have this down in the function. IIRC I had checked out tag
mmotm-2017-06-16-13-59 where I am looking out for this function.

for (i = 0; i < nr_pages; i++) {
	unsigned long pfn = start_pfn + i;
	set_page_links(pfn_to_page(pfn), zone_idx(zone), nid, pfn);
}