linux-kernel - Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 12:25:39 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     Wolfram Sang <wsa@...-dreams.de>, Rob Herring <robh+dt@...nel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc

On Mon, Jun 26, 2017 at 3:44 AM, Chris Packham
<chris.packham@...iedtelesis.co.nz> wrote:
> Make use of struct gpio_desc which allows us to specify the active state
> of the reset pin.

> +               if (gpio_is_valid(platform_data->gpio)) {

No way, it should be provided by GPIO lookup table.

> +                       ret = devm_gpio_request_one(&pdev->dev,
> +                                                   platform_data->gpio,
> +                                                   GPIOF_ACTIVE_LOW,
> +                                                   i2c->adap.name);
> +                       if (ret == 0) {
> +                               i2c->gpio = gpio_to_desc(platform_data->gpio);

This has to be devm_gpiod_get() instead.

Wolfram, I suggested to drop the series for now and wait for improvements.

-- 
With Best Regards,
Andy Shevchenko