lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Jun 2017 11:08:17 +0800 From: Jeremy Kerr <jk@...abs.org> To: Eddie James <eajames@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org Cc: linux-i2c@...r.kernel.org, devicetree@...r.kernel.org, wsa@...-dreams.de, robh+dt@...nel.org, gregkh@...uxfoundation.org, joel@....id.au, andrew@...id.au, "Edward A. James" <eajames@...ibm.com> Subject: Re: [PATCH 6/6] Documentation/devicetree: Add FSI-attached I2C master dt bindings Hi Eddie, >> Those child nodes represent the downstream i2c buses, and so also >> contain the i2c slave devices, right? If so, you may want to document >> that, and/or add a simple device to that example (say, an EEPROM). > > Yes, good point, but the driver currently wouldn't do anything with that > device information. It doesn't keep a list of populated devices on the > bus or anything. Still worth adding them to the device tree? Surely the i2c core needs this to be able to find i2c slave devices on the bus though? [You'll need to set i2c_adapter->dev.of_node for this to work though, which I don't think you are with the current patch set] Cheers, Jeremy
Powered by blists - more mailing lists