linux-kernel - Re: [RFC PATCH 0/2] mmc: sdhci: Add SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 22:51:57 +0530
From:   Ritesh Harjani <riteshh@...eaurora.org>
To:     srinivas.kandagatla@...aro.org,
        Adrian Hunter <adrian.hunter@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [RFC PATCH 0/2] mmc: sdhci: Add
 SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER

Hi Srinivas,

On 6/28/2017 7:05 PM, srinivas.kandagatla@...aro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> This patchset adds quirk to support cards which have issues when sdma
> boundary buffer bits are programmed in Block Size Register (0x04)
> when using ADMA.

Thanks for pointing out the reason of failure without this patch.
Earlier I could not find the reason.

Previous discussion link :-
https://patchwork.kernel.org/patch/9200579/


> 
> First patch adds quirk and second one uses that quirk in msm sdhci driver.

Not sure if quirk will be the right way to go about this, or whether we 
should make this functionality default since ADMA does not
uses this (as per spec) ?
Since other systems should not break (as Adrian was mentioning in the 
discussion link above).

Adrian/Ulf will know better on this.

> 
> Tested on DB410c with WLAN SDIO card.
> 
> thanks,
> srini
> 
> Srinivas Kandagatla (2):
>    mmc: sdhci: add quirk SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER
>    mmc: sdhci-msm: enable SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER
> 
>   drivers/mmc/host/sdhci-msm.c |  3 ++-
>   drivers/mmc/host/sdhci.c     | 24 ++++++++++++++++++------
>   drivers/mmc/host/sdhci.h     |  2 ++
>   3 files changed, 22 insertions(+), 7 deletions(-)
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project