linux-kernel - [PATCH] libata: fix build warning in ata_scsi_var_len_cdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 22:04:03 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Tejun Heo <tj@...nel.org>
Cc:     Bart Van Assche <bart.vanassche@....com>,
        Arnd Bergmann <arnd@...db.de>, Tom Yan <tom.ty89@...il.com>,
        Hannes Reinecke <hare@...e.de>,
        Shaun Tancheff <shaun@...cheff.com>,
        Adam Manzanares <adam.manzanares@....com>,
        Minwoo Im <dn3108@...il.com>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] libata: fix build warning in ata_scsi_var_len_cdb_xlat

This new harmless warning just showed up:

drivers/ata/libata-scsi.c: In function 'ata_scsi_var_len_cdb_xlat':
drivers/ata/libata-scsi.c:4194:1: error: label 'unspprt_sa' defined but not used [-Werror=unused-label]

The label is obviously unused and can be removed.

Fixes: b1ffbf854e08 ("libata: Support for an ATA PASS-THROUGH(32) command.")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/ata/libata-scsi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 815c6e240aea..9d1b66b4ce7b 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -4191,7 +4191,6 @@ static unsigned int ata_scsi_var_len_cdb_xlat(struct ata_queued_cmd *qc)
 	if (sa == ATA_32)
 		return ata_scsi_pass_thru(qc);
 
-unspprt_sa:
 	/* unsupported service action */
 	return 1;
 }
-- 
2.9.0