linux-kernel - Re: [PATCH] trace-listen: add missing header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2017 08:19:56 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace-listen: add missing header

On Thu, 29 Jun 2017 14:46:21 +0300
Baruch Siach <baruch@...s.co.il> wrote:

> The PATH_MAX macro requires the limits.h header. This fixes build with musl
> libc:
> 
> .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’:
> .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function)
>   snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
>                 ^~~~~~~~

Thanks! I have a few other patches that need to go into trace-cmd. I'll
try to get to that today or tomorrow.

-- Steve

> 
> Signed-off-by: Baruch Siach <baruch@...s.co.il>
> ---
>  trace-listen.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/trace-listen.c b/trace-listen.c
> index 17ff9d8c160c..838d6bcf3649 100644
> --- a/trace-listen.c
> +++ b/trace-listen.c
> @@ -31,6 +31,7 @@
>  #include <fcntl.h>
>  #include <signal.h>
>  #include <errno.h>
> +#include <limits.h>
>  
>  #include "trace-local.h"
>  #include "trace-msg.h"