linux-kernel - Re: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when napi is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2017 15:35:51 +0100
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Hayes Wang <hayeswang@...ltek.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Sasha Levin <alexander.levin@...izon.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when
 napi is disabled

On Thu, 2017-06-15 at 19:52 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: hayeswang <hayeswang@...ltek.com>
> 
> 
> [ Upstream commit de9bf29dd6e4a8a874cb92f8901aed50a9d0b1d3 ]
> 
> Stop the tx when the napi is disabled to prevent napi_schedule() is
> called.
[...]
> +	netif_stop_queue(netdev);
>  	napi_disable(&tp->napi);
[...]

netif_stop_queue() is not synchronous, so you probably need
netif_tx_disable() instead.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.