linux-kernel - Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2017 14:10:16 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Peter Griffin <peter.griffin@...aro.org>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "Liuxinliang (Matthew Liu)" <z.liuxinliang@...ilicon.com>,
        Rongrong Zou <zourongrong@...il.com>,
        XinWei Kong <kong.kongxinwei@...ilicon.com>,
        Feng Chen <puck.chen@...ilicon.com>,
        David Airlie <airlied@...ux.ie>,
        stable <stable@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Andrey Konovalov <andrey.konovalov@...aro.org>,
        Fathi Boudra <fathi.boudra@...aro.org>
Subject: Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.

On Thu, Jun 29, 2017 at 1:54 PM, Peter Griffin <peter.griffin@...aro.org> wrote:
> This patch fixes the following soft lockup:
>   BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
>
> On weston idle-timeout the IP is powered down and reset
> asserted. On weston resume we get a massive vblank
> IRQ storm due to the LDI registers having lost some state.
>
> This state loss is caused by ade_crtc_atomic_begin() not
> calling ade_ldi_set_mode(). With this patch applied
> resuming from Weston idle-timeout works well.
>
> Signed-off-by: Peter Griffin <peter.griffin@...aro.org>

While the issue hasn't seemingly come up with Android, I've been
running with this patch in my tree for a while without issue. So..
Tested-by: John Stultz <john.stultz@...aro.org>

thanks
-john