linux-kernel - Re: [PATCH v2] pata_imx: print error message on platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Jun 2017 16:47:37 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Tejun Heo <tj@...nel.org>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pata_imx: print error message on platform_get_irq
 failure


Quoting Sergei Shtylyov <sergei.shtylyov@...entembedded.com>:

> On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote:
>
>> Print error message on platform_get_irq failure before return.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>> ---
>> Changes in v2:
>> Print the return value of platform_get_irq on failure.
>>
>> drivers/ata/pata_imx.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c
>> index d4caa23..66fb1ab 100644
>> --- a/drivers/ata/pata_imx.c
>> +++ b/drivers/ata/pata_imx.c
>> @@ -132,9 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev)
>> 	int ret;
>>
>> 	irq = platform_get_irq(pdev, 0);
>> -	if (irq < 0)
>> +	if (irq < 0) {
>> +		dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq);
>> 		return irq;
>> -
>> +	}
>
>    Removing empty line here doesn't seem a good idea...
>

Oh yeah, I agree.
I'll send v3 shortly.

Thanks!
--
Gustavo A. R. Silva