lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 1 Jul 2017 16:50:49 +0900 From: MyungJoo Ham <myungjoo.ham@...sung.com> To: Chanwoo Choi <cw00.choi@...sung.com> Cc: "Gustavo A. R. Silva" <garsilva@...eddedor.com>, Kyungmin Park <kyungmin.park@...sung.com>, Linux PM list <linux-pm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <cw00.choi@...sung.com> wrote: > Hi, > > On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote: >> Print and propagate the return value of platform_get_irq on failure. >> >> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com> >> --- >> drivers/devfreq/rk3399_dmc.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >> index 40a2499..1b89ebb 100644 >> --- a/drivers/devfreq/rk3399_dmc.c >> +++ b/drivers/devfreq/rk3399_dmc.c >> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) >> >> irq = platform_get_irq(pdev, 0); >> if (irq < 0) { >> - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); >> - return -EINVAL; >> + dev_err(&pdev->dev, >> + "Cannot get the dmc interrupt resource: %d\n", irq); >> + return irq; >> } >> data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); >> if (!data) >> > > Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com> Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com> > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics
Powered by blists - more mailing lists