linux-kernel - Re: [PATCH 2/3] drivers: remoteproc: Add Hexagon Q6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Jul 2017 18:30:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sricharan R <sricharan@...eaurora.org>
Cc:     kbuild-all@...org, ohad@...ery.com, bjorn.andersson@...aro.org,
        robh+dt@...nel.org, mark.rutland@....com, andy.gross@...aro.org,
        david.brown@...aro.org, linux-remoteproc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        sricharan@...eaurora.org
Subject: Re: [PATCH 2/3] drivers: remoteproc: Add Hexagon Q6 - WCSS
 integrated core driver

Hi Sricharan,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.12-rc7 next-20170630]
[cannot apply to remoteproc/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sricharan-R/drivers-remoteproc-Make-mdt_loader-firmware-authentication-optional/20170702-123208
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers//remoteproc/q6v5-wcss.c: In function 'q6_rproc_probe':
>> drivers//remoteproc/q6v5-wcss.c:126:14: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
      qproc->clks[i++] = c;
                 ^
   drivers//remoteproc/q6v5-wcss.c:103:6: note: 'i' was declared here
     int i;
         ^

vim +/i +126 drivers//remoteproc/q6v5-wcss.c

   110		if (!qproc->clk_cnt)
   111			return 0;
   112	
   113		qproc->clks = devm_kzalloc(dev, sizeof(*qproc->clks) * qproc->clk_cnt,
   114					   GFP_KERNEL);
   115	
   116		of_property_for_each_string(dev->of_node, "clock-names", prop, cname) {
   117			struct clk *c = devm_clk_get(dev, cname);
   118	
   119			if (IS_ERR_OR_NULL(c)) {
   120				if (PTR_ERR(c) != -EPROBE_DEFER)
   121					dev_err(dev, "Failed to get %s clock\n", cname);
   122	
   123				return PTR_ERR(c);
   124			}
   125	
 > 126			qproc->clks[i++] = c;
   127		}
   128	
   129		return 0;
   130	}
   131	
   132	static int q6v5_clk_enable(struct q6v5 *qproc)
   133	{
   134		int rc;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (55833 bytes)